Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(git-hooks): Add git-build-hook-maven-plugin + pre-push hook #5

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

f-lopes
Copy link
Contributor

@f-lopes f-lopes commented Jun 11, 2023

Add git-build-hook-maven-plugin + pre-push hook

@GoncaloPT
Copy link
Collaborator

Hello @f-lopes. Would you care to explain the reason for this?

@f-lopes
Copy link
Contributor Author

f-lopes commented Jun 22, 2023

Hello @GoncaloPT

It's a safeguard, preventing users from pushing "non-compliant" changes (build failure, format errors, etc.).

I think it's a great way for an open-source library to "guide" the contributors.

@GoncaloPT
Copy link
Collaborator

I see your point. But it would also prevent me to share code with someone else if I want to work together with you for example on the same branch.
I believe a better place to have the safeguard you suggest is on the pull request, having the clean package there, validating your pull request.
What do you think?

@f-lopes
Copy link
Contributor Author

f-lopes commented Jun 22, 2023

You can still disable hook using the --no-verify flag if needed (git push --no-verify).

@f-lopes f-lopes force-pushed the build/git-build-hook-plugin branch from 44cd865 to 687a5a6 Compare June 23, 2023 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants